Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish step to strip v from version #118

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

tstirrat15
Copy link
Contributor

Description

We want to standardize on a v-prefixed release, but Maven and the java ecosystem don't like those. This fixes that using the same technique that we've been using in other repos to strip the v prefix.

Changes

  • Reindent some things
  • Add release version writing

Testing

Review. View with ?w=1 on the diff to see the non-whitespace changes.

@tstirrat15 tstirrat15 requested a review from a team November 14, 2024 18:03
@tstirrat15 tstirrat15 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 5ca9e84 Nov 14, 2024
14 checks passed
@tstirrat15 tstirrat15 deleted the fix-publish-step-to-strip-v branch November 14, 2024 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants