More Lint Fixes #43
Merged
More Lint Fixes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tstirrat15
commented
Jan 22, 2025
| @@ -58,6 +58,15 @@ interface VisGraphDefinition<N extends VisNode, E extends VisEdge> { | |||
| nodes: N[], edges: E[] | |||
| } | |||
|
|
|||
| interface VisDataSet { | |||
| update: (data: object) => void | |||
There was a problem hiding this comment.
object is like one step above any, but it's useful when you just want to say "yeah it's an object"
| @@ -403,7 +403,7 @@ function generateExpressionGraph( | |||
| const edges: LocalEdge[] = []; | |||
|
|
|||
| switch (expression.kind) { | |||
| case 'relationref': | |||
| case 'relationref': { | |||
There was a problem hiding this comment.
Wrapping blocks in brackets so that the declarations are properly scoped
| @@ -91,11 +92,13 @@ describe('parsing', () => { | |||
|
|
|||
| expect(parsed?.definitions?.length).toEqual(1); | |||
|
|
|||
| const definition = parsed?.definitions[0]! as ParsedObjectDefinition; | |||
| const definition = parsed?.definitions[0]; | |||
| assert(definition) | |||
There was a problem hiding this comment.
Using insert instead of type assertions
alecmerdler
approved these changes
Jan 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closer to getting lint sorted.
Changes
Testing
Review. See that things pass.