implement a more flexible logging middleware #1416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the community has signaled interest for more flexibility around configuring the logs emitted by SpiceDB, but it's limited to what the grpc logging middleware supports. Implementing a new middleware isn't a lot of work, it gives the opportunity to find optimizations, and gives more flexibility on what kind of features SpiceDB should support. This initial implementation tries to adhere as close as possible to the original middleware logs, but with a few changes: - request payloads can be omitted based on an exclusion list - response payloads can be omitted based on an exclusion list - entire methods can be omitted based on an exclusion list (e.g. do not log healthcheck) - time is reported as milliseconds instead of a duration. This makes it easy to craft queries in any log processor based on duration (e.g. which where the requests that took more than 25ms?)
vroldanbet
force-pushed
the
flexible-request-logging
branch
from
787d8c8 to
b4a7be3
Compare
|
Will reopen when rescheduled |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the community has signaled interest for more flexibility around configuring the logs emitted by SpiceDB, but it's limited to what the grpc logging middleware supports.
Implementing a new middleware isn't a lot of work, it gives the opportunity to find optimizations, and gives more flexibility on what kind of features SpiceDB should support.
This initial implementation tries to adhere as close as possible to the original middleware logs, but with a few changes: