Compare tuples without stringifying #1562
Conversation
github-actions
bot
added
area/datastore
| // TODO(jschorr): Use a faster method then string comparison for caveats. | ||
| return OnrEqual(lhs.ResourceAndRelation, rhs.ResourceAndRelation) && OnrEqual(lhs.Subject, rhs.Subject) && MustStringCaveat(lhs.Caveat) == MustStringCaveat(rhs.Caveat) |
There was a problem hiding this comment.
We still stringify the caveat if everything else matches. There might be some optimizations that could be made here. For example, we could count the keys before stringifying. I'm not sure if this is worth doing.
There was a problem hiding this comment.
There is a function in the codebase that computes a hash of the caveat context. I'm not sure that'd be faster than stringifying tho.
bradengroom
force-pushed
the
fast-compare-tuple
branch
from
430ff42 to
cd07e1d
Compare
| return lhs.ObjectId == rhs.ObjectId && lhs.Relation == rhs.Relation && lhs.Namespace == rhs.Namespace | ||
| } | ||
|
|
||
| func OnrEqualOrWildcard(tpl, target *core.ObjectAndRelation) bool { |
There was a problem hiding this comment.
do we have tests for this?
There was a problem hiding this comment.
Nope! They aren't new really. I just relocated them from internal/graph/check.go. I can write tests though
|
Added tests for the equality functions. The caveat hashing function I found looked like it accepts a different type (protobuf struct?) than I have. I wasn’t sure how strongly you felt about using the hashing function, but I’m happy to look into it more if you want. |
This updates the mysql datastore to compare tuples without stringifying.