log payloads, and add grpc duration as an integer #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
changed the title
vroldanbet
force-pushed
the
tweak-logs
branch
from
3f5d200 to
844e0a9
Compare
github-actions
bot
added
area/dependencies
ecordell
reviewed
Oct 26, 2023
jzelinskie
requested changes
Oct 26, 2023
pkg/cmd/serve.go
Outdated
| @@ -47,6 +47,10 @@ func RegisterServeFlags(cmd *cobra.Command, config *server.Config) error { | |||
| config.DispatchClusterMetricsEnabled = true | |||
| config.DispatchClientMetricsEnabled = true | |||
|
|
|||
| // Flags for logging | |||
| cmd.Flags().BoolVar(&config.EnableRequestLogs, "enable-request-logs", false, "logs API request payloads") | |||
There was a problem hiding this comment.
Flags need to be named with a prefix for the subsystem they control, so that they are grouped together.
We should prefix this with grpc or log; probably log.
Any existing flags that start with enable were mistakes and should probably have their flags hidden and new ones introduced.
There was a problem hiding this comment.
grpc-request-logs-enabled grpc-repsonse-logs-enabled
vroldanbet
force-pushed
the
tweak-logs
branch
from
01fe548 to
9f89899
Compare
vroldanbet
force-pushed
the
tweak-logs
branch
from
9f89899 to
e5eb8f3
Compare
jzelinskie
approved these changes
Oct 26, 2023
in order to better troubleshoot certain situations, it would be useful to load request and response payloads. Also in certain log aggregators it's not possible to convert duration fields that are represented as a string, and this is useful in order to filter requests by a specific duration threshold. This commit changes the duration function to log it as an integer
jzelinskie
force-pushed
the
tweak-logs
branch
from
e5eb8f3 to
1b8fa4c
Compare
jzelinskie
approved these changes
Oct 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to better troubleshoot certain situations, it would be useful to load request and response payloads.
Also in certain log aggregators it's not possible to convert duration fields that are represented as a string, and this is useful in order to filter requests by a specific duration threshold. This commit changes the duration function to log it as an integer
Adds options to control request and response payloads via CLI