Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parallelization of PG tests and see if that fixes flakes #1653

Closed
wants to merge 1 commit into from
Closed

Remove parallelization of PG tests and see if that fixes flakes #1653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions internal/datastore/postgres/pgbouncer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,9 @@ var pgbouncerConfigs = lo.Map(
)

func TestPostgresWithPgBouncerDatastore(t *testing.T) {
t.Parallel()

testPostgresDatastore(t, pgbouncerConfigs)
}

func TestPostgresDatastoreWithPgBouncerWithoutCommitTimestamps(t *testing.T) {
t.Parallel()

testPostgresDatastoreWithoutCommitTimestamps(t, pgbouncerConfigs)
}
3 changes: 0 additions & 3 deletions internal/datastore/postgres/postgres_shared_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ func testPostgresDatastore(t *testing.T, pc []postgresConfig) {
pgbouncerStr = "pgbouncer-"
}
t.Run(fmt.Sprintf("%spostgres-%s-%s-%s", pgbouncerStr, config.pgVersion, config.targetMigration, config.migrationPhase), func(t *testing.T) {
t.Parallel()
b := testdatastore.RunPostgresForTesting(t, "", config.targetMigration, config.pgVersion, config.pgbouncer)

test.All(t, test.DatastoreTesterFunc(func(revisionQuantization, gcInterval, gcWindow time.Duration, watchBufferLength uint16) (datastore.Datastore, error) {
Expand Down Expand Up @@ -198,8 +197,6 @@ func testPostgresDatastoreWithoutCommitTimestamps(t *testing.T, pc []postgresCon
pgVersion := config.pgVersion
enablePgbouncer := config.pgbouncer
t.Run(fmt.Sprintf("postgres-%s", pgVersion), func(t *testing.T) {
t.Parallel()

b := testdatastore.RunPostgresForTestingWithCommitTimestamps(t, "", "head", false, pgVersion, enablePgbouncer)

// NOTE: watch API requires the commit timestamps, so we skip those tests here.
Expand Down
4 changes: 0 additions & 4 deletions internal/datastore/postgres/postgres_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,9 @@ import (
)

func TestPostgresDatastore(t *testing.T) {
t.Parallel()

testPostgresDatastore(t, postgresConfigs)
}

func TestPostgresDatastoreWithoutCommitTimestamps(t *testing.T) {
t.Parallel()

testPostgresDatastoreWithoutCommitTimestamps(t, postgresConfigs)
}