-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goreleaser: init snap, linux shell completions #1744
Conversation
Hey Jimmy, do you need any assistance moving this forward? There's some simple CI work we could do to start pushing this out to |
5e8179f
to
e2d3849
Compare
Thanks for checking in @jnsgruk. I've got snaps building. I took a bit longer for this PR because I also added shell completions to our Linux packages; is there a standard way to add this for snaps? Otherwise I'm ready to take your lead on how to get things pushed to the snap store. |
Great! Yep there is a standard way to do that: https://snapcraft.io/docs/tab-completion There is an example here: https://github.com/canonical/multipass/blob/8c7a2266f7c084ff81611409da0d3c71c0a8fbbc/snap/snapcraft.yaml#L85 |
It looks like my last commit does the trick, but it doesn't follow the What's next to get this plugged into the snap store channels? |
Next step would be to register your snap name. I'd recommend using a company account for signing up to snapcraft.io (like [email protected] or similar) so we can get it verified later. Once you've signed up and registered, you'll need to export a token and set it in Github Actions secret as the variable Finally - set up a job that publishes the |
Looking at the goreleaser docs, you may need something like so in your extra_files:
- source: completions/spicedb.bash
destination: completions/spicedb.snap
mode: 0755 Which will actually stage the completer, with the bonus that you can follow the snapcraft naming convention? |
I'm not sure why, but extra_files appears to do nothing and I can only get |
Sorry about this -- I was traveling for KubeCon and on vacation. Getting back to it soon. |
@jnsgruk is the naming convention there a dealbreaker? I'd like to get this moving along and maybe we can go back and address that after we kick the tires with some of the publishing pipeline. |
Hey @jzelinskie! I did a bit of digging this morning, and I think the naming is fine. I also came across this guide for debugging it if we run into problems. I note that in the example there they use: name: foo
version: v1
apps:
bar:
command: bar
completer: bar-completer.sh # this is the one! So I think you're good! |
nightly.goreleaser.yml => .goreleaser.nightly.yml This change is intended to make it more difficult to forget to update nightly config when making any changes to the primary goreleaser config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shoutouts to @jnsgruk and @caarlos0 for guidance around snaps and packaging completion for goreleaser!