Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the parent context in serve_test when complete #1763

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

josephschorr
Copy link
Member

No description provided.

@github-actions github-actions bot added area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Feb 23, 2024
@josephschorr josephschorr marked this pull request as ready for review February 23, 2024 18:19
@josephschorr josephschorr requested a review from a team February 23, 2024 18:20
pkg/cmd/serve_test.go Outdated Show resolved Hide resolved
@josephschorr josephschorr force-pushed the close-in-test-when-done branch from 9dfbbf1 to 500a848 Compare February 23, 2024 18:50
@josephschorr josephschorr force-pushed the close-in-test-when-done branch from 500a848 to 4977627 Compare February 23, 2024 18:53
@jzelinskie jzelinskie enabled auto-merge February 23, 2024 18:58
@jzelinskie jzelinskie added this pull request to the merge queue Feb 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 23, 2024
@josephschorr josephschorr added this pull request to the merge queue Feb 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 23, 2024
@josephschorr josephschorr added this pull request to the merge queue Feb 23, 2024
Merged via the queue into authzed:main with commit dcd3967 Feb 23, 2024
20 checks passed
@josephschorr josephschorr deleted the close-in-test-when-done branch February 23, 2024 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants