Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import request ID metadata key from authzed-go #1829

Merged

Conversation

alecmerdler
Copy link
Contributor

Aligns the code with how we import other gRPC metadata keys from authzed-go.

@alecmerdler alecmerdler self-assigned this Mar 20, 2024
@alecmerdler alecmerdler requested a review from a team March 20, 2024 20:58
@alecmerdler alecmerdler changed the title Import request ID metadata key from authzed-go Import request ID metadata key from authzed-go Mar 20, 2024
@alecmerdler alecmerdler force-pushed the requestid-import-from-authzed-go branch from b213aee to bbd7374 Compare March 20, 2024 21:11
vroldanbet
vroldanbet previously approved these changes Mar 21, 2024
@alecmerdler alecmerdler force-pushed the requestid-import-from-authzed-go branch from bbd7374 to b1a8c53 Compare March 21, 2024 15:12
@alecmerdler alecmerdler force-pushed the requestid-import-from-authzed-go branch from b1a8c53 to 5d7ee07 Compare March 21, 2024 16:03
@vroldanbet vroldanbet force-pushed the requestid-import-from-authzed-go branch from 5d7ee07 to 315fd39 Compare March 21, 2024 16:09
@alecmerdler alecmerdler force-pushed the requestid-import-from-authzed-go branch from 315fd39 to 0d568da Compare March 21, 2024 16:13
@vroldanbet vroldanbet force-pushed the requestid-import-from-authzed-go branch from 0d568da to 2f11ac5 Compare March 21, 2024 17:19
vroldanbet
vroldanbet previously approved these changes Mar 21, 2024
@vroldanbet vroldanbet enabled auto-merge March 21, 2024 17:19
@alecmerdler alecmerdler force-pushed the requestid-import-from-authzed-go branch from 2f11ac5 to 5e79ffa Compare March 21, 2024 17:33
Aligns the code with how we import other gRPC metadata keys
from 'authzed-go'.
@alecmerdler
Copy link
Contributor Author

Could I get a re-review @vroldanbet? I needed to rebase, sorry.

@alecmerdler alecmerdler requested a review from vroldanbet March 21, 2024 17:43
@vroldanbet vroldanbet disabled auto-merge March 21, 2024 17:50
@vroldanbet vroldanbet merged commit 3fff19f into authzed:main Mar 21, 2024
19 of 21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants