Use type information to optimize TOUCH operations in the PG datastore #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
pg-touch-optimization
branch
from
13a9ba0 to
2c18f0a
Compare
vroldanbet
reviewed
Mar 25, 2024
| return relationSupportSimplifiedTouch, nil | ||
| } | ||
|
|
||
| namespaces, err := rwt.LookupNamespacesWithNames(ctx, touchedResourceNamespaces.AsSlice()) |
There was a problem hiding this comment.
So we are trading of an UPDATE for an extra SELECT operation.
There was a problem hiding this comment.
A much smaller SELECT operation, since it is only loading the namespaces needed
There was a problem hiding this comment.
well it depends - it could be an update that has many different namespaces, with namespace bytes that then have to be transferred over the write while the transaction is opened, VS an update that runs purely on the server-side
When a TOUCH is performed over a relationship for a relation+subject type that cannot be caveated, we can skip the UPDATE query used to check for the caveat changing, which is a significant performance boost
josephschorr
force-pushed
the
pg-touch-optimization
branch
from
2c18f0a to
59a18b4
Compare
github-actions
bot
added
area/datastore
vroldanbet
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a TOUCH is performed over a relationship for a relation+subject type that cannot be caveated, we can skip the UPDATE query used to check for the caveat changing, which is a significant performance boost