Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aws iam authentication for mysql #1867

Merged
merged 1 commit into from
Apr 24, 2024
Merged

add aws iam authentication for mysql #1867

merged 1 commit into from
Apr 24, 2024

Conversation

j-white
Copy link
Contributor

@j-white j-white commented Apr 16, 2024 •
edited
Loading

Building off of #1858, adds similar support for MySQL

Marking this as a draft since I haven't validated on AWS yet
Validated with MySQL Community on AWS

@github-actions github-actions bot added area/CLI Affects the command line area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Apr 16, 2024
@j-white j-white force-pushed the jw/mysql-iam-auth branch from 77d32da to 0d5a32d Compare April 16, 2024 23:05
@j-white j-white marked this pull request as ready for review April 16, 2024 23:06
@j-white j-white requested a review from vroldanbet as a code owner April 16, 2024 23:06
@j-white j-white requested a review from a team April 16, 2024 23:06
josephschorr
josephschorr reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a datastore test for MySQL to use it as well?

internal/datastore/mysql/datastore.go Outdated Show resolved Hide resolved
internal/datastore/mysql/migrations/driver.go Outdated Show resolved Hide resolved
internal/datastore/mysql/migrations/driver.go Outdated Show resolved Hide resolved
internal/datastore/postgres/options.go Outdated Show resolved Hide resolved
josephschorr
josephschorr reviewed Apr 23, 2024
View reviewed changes
internal/datastore/mysql/common/credentials.go Show resolved Hide resolved
internal/datastore/mysql/datastore.go Show resolved Hide resolved
internal/datastore/mysql/datastore_test.go Show resolved Hide resolved
internal/datastore/mysql/migrations/driver.go Show resolved Hide resolved
internal/datastore/mysql/options.go Outdated Show resolved Hide resolved
internal/datastore/postgres/options.go Outdated Show resolved Hide resolved
pkg/datastore/credentials.go Outdated Show resolved Hide resolved
pkg/datastore/credentials.go Show resolved Hide resolved
@josephschorr
Copy link
Member

Please rebase as well

@j-white j-white force-pushed the jw/mysql-iam-auth branch 2 times, most recently from b57bd08 to 9b7ee22 Compare April 23, 2024 20:29
@j-white j-white force-pushed the jw/mysql-iam-auth branch from 9b7ee22 to 72380c5 Compare April 23, 2024 20:59
josephschorr
josephschorr approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr added this pull request to the merge queue Apr 24, 2024
Merged via the queue into authzed:main with commit 7bd975f Apr 24, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
@j-white j-white deleted the jw/mysql-iam-auth branch April 24, 2024 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

@vroldanbet vroldanbet Awaiting requested review from vroldanbet vroldanbet is a code owner

Assignees
No one assigned
Labels
area/CLI Affects the command line area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-white @josephschorr