Move caveat loading into a shared runner to reduce overhead in dispatch #2179
+219
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
alecmerdler
reviewed
Dec 30, 2024
| } | ||
|
|
||
| func runExpression( | ||
| // RunCaveatExpression runs a caveat expression over the given context and returns the result. | ||
| func (cr *CaveatRunner) RunCaveatExpression( |
There was a problem hiding this comment.
It looks like we might be missing a unit test for this new struct and method.
There was a problem hiding this comment.
RunSingleCaveatExpression does invoke this method, but I'll add a unit test just the same
josephschorr
force-pushed
the
caveat-opts
branch
from
3ab909a to
5c44ab5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than re-processing the caveat on each iteration of the relationships loop in LR2, we use a caching loader to only process once per caveat