Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon: Mugen #139

Closed
wants to merge 10 commits into from

Conversation

Creativty
Copy link
Contributor

@Creativty Creativty commented Nov 15, 2024

What did we do

  • GCC's builtin_expect for AReal's constructor and destructor (App#3 and App#2 targets)
  • GCC's bultin_expect for ChunkContainer::check_space (All apps are targeted)
  • XAD_FORCE_INLINE for ChunkContainer::push_back (All apps are targeted)
  • Merge the multiplier_ and slot_ chunk containers into one pairs_ to help automatic vectorization of final asm (All apps are targeted).
  • Optimize the inner most for loop in computeAdjointsToImpl via simplification of code (All apps are targeted)

Team Members:

  • Salah-eddine Ouahidi (tardi)
  • Abderrahim Indjaren (XENOBAS)
  • Yasser Ait Nasser (yait-nas)

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Creativty
✅ auto-differentiation-dev
❌ souahidi


souahidi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Nov 16, 2024

Test Results

    29 files      29 suites   14m 41s ⏱️
 1 319 tests  1 319 ✅ 0 💤 0 ❌
48 061 runs  48 061 ✅ 0 💤 0 ❌

Results for commit 927f2af.

♻️ This comment has been updated with latest results.

@coveralls
Copy link
Collaborator

coveralls commented Nov 16, 2024

Pull Request Test Coverage Report for Build 11867546790

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 47 of 48 (97.92%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 98.639%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/XAD/ChunkContainer.hpp 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
src/XAD/ChunkContainer.hpp 3 95.86%
Totals Coverage Status
Change from base Build 11867528509: -0.09%
Covered Lines: 2391
Relevant Lines: 2424

💛 - Coveralls

@auto-differentiation-dev
Copy link
Collaborator

Results:

App Reference Optimised Improvement
Monte-Carlo Swaption Pricer (App 1) 13.583s 6.618s 51.277%
Bermudan Swaption Pricer (App 2) 33.02104ms 23.446225ms 28.996%
QuantLib Overhead (App 3) 4060665us 3839281us 5.452%

@auto-differentiation-dev
Copy link
Collaborator

Closing this PR as key changes have been incorporated into #150, which consolidates contributions from multiple submissions. Thank you all for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants