WIP implement mentions + findUser falls back to webfinger #28
+124
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autogestion
reviewed
Mar 22, 2020
philip/src/components/Publish.svelte
Outdated
| const data = wrapHashTagsWithLink(wrapLinksWithTags(content)); | ||
|
|
||
| let ap_object = getCreateObject(data, tags); | ||
| const data = wrapMentions(wrapHashTagsWithLink(wrapLinksWithTags(content))); |
|
|
|
and renders incorrect url in cc (which will be used by server to notify person which was mentioned) |
- Publish ("Create"): separate publish and sendPost
- Search: factor out requests to utils/user.js
- needs testing for non-pgi
|
thanks for testing! needs some more :) |
traumschule
changed the title
|
Have tested mentions, works fine Same time, fallback to webginger failed when tried to search for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #26, #27
Note: the output specification requires
"cc": [<user_id>]. When mentioning multiple users backend raised 500 because the cc list was inserted as an array. Hence line 46 in Publish.svelte isap_object.cc = mentions.map(m => m.href);instead ofap_object.cc = [mentions.map(m => m.href)];