Fix viewing GitHub submissions

[NicholasMy]

(cherry picked from commit 78f7933)

Description

The File.cleanpath method used in Archive.sanitize_directories comes from the Yard package, which is only installed in development. This results in errors in production when viewing a GitHub submission. I rewrote a line in sanitize_directories to avoid using that library.

Here's a demonstration of the method not existing in production using a debugger:

And here's the generic error displayed on Autolab when attempting to view a GitHub submission's contents:

How Has This Been Tested?

After making the change to use the Pathname class instead, I verified I'm able to view the contents of a GitHub submission through the UI.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes modify the sanitize_directories method in the Archive module. The update changes the path sanitization approach by replacing File.cleanpath with Pathname.new(...).cleanpath.to_s. This alteration refines how relative paths are handled without affecting the overall directory structure logic or control flow. No new features or changes to the public API are introduced.

Changes

File	Change Summary
lib/archive.rb	Updated sanitize_directories to use Pathname.new(...).cleanpath.to_s instead of File.cleanpath for pathname sanitization.

Suggested reviewers

• evanyeyeye
• damianhxy

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 RuboCop (1.69.1)

lib/archive.rb

Error: No such file or directory: /lib/archive.rb
{"metadata":{"rubocop_version":"1.69.1","ruby_engine":"ruby","ruby_version":"3.1.2","ruby_patchlevel":"20","ruby_platform":"x86_64-linux-gnu"},"files":[{"path":"lib/archive.rb","offenses":[]}],"summary":{"offense_count":0,"target_file_count":1,"inspected_file_count":0}}

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 320631b and 8a5b5a7.

📒 Files selected for processing (1)

• lib/archive.rb (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: lint
• GitHub Check: test
• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

lib/archive.rb (1)

74-74: LGTM! Good choice using Ruby's standard library.

The change from File.cleanpath to Pathname.new(...).cleanpath.to_s is a solid improvement:

• Eliminates the development-only dependency on Yard package
• Uses Ruby's standard library functionality, ensuring availability in all environments
• Maintains the same path normalization behavior

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.