Hashing based Verification Token Handling #43
Conversation
|
This also fixes the bug in reverify email. @liam-sbhoo |
anshulg954
force-pushed
the
hashed_reduced_len_token
branch
from
7eb9963
to
38f2546
Compare
tabpfn_client/config.py
Outdated
| @@ -44,6 +44,7 @@ def init(use_server=True): | |||
| ): | |||
| print("Your email is not verified. Please verify your email to continue...") | |||
| PromptAgent.reverify_email(is_valid_token_set[1], user_auth_handler) | |||
| user_auth_handler.set_token(is_valid_token_set[1]) | |||
There was a problem hiding this comment.
Can you adapt line 38 and replace the array / tuple by two separate variables
A, B = user_auth_handler.try_reuse_existing_token() # with A, B replace by what that means
There was a problem hiding this comment.
Sure. change accomodated, I did this initially to have minimal changes in the inner function try_reuse_existing_token.
tabpfn_client/prompt_agent.py
Outdated
| ) | ||
| if not is_created: | ||
| raise RuntimeError("User registration failed: " + str(message) + "\n") | ||
|
|
||
| print( | ||
| cls.indent( | ||
| "Account created successfully! To start using TabPFN please click on the link in the verification email we sent you." | ||
| "Account created successfully! To start using TabPFN please enter the secret key in the verification email we sent you." |
There was a problem hiding this comment.
To start using TabPFN please enter the verification code we sent to you by mail
tabpfn_client/prompt_agent.py
Outdated
| cls.indent( | ||
| "Thank you for verifying your email successfully! Your access token is: " | ||
| ) | ||
| + access_token |
There was a problem hiding this comment.
Don't show the access token here. Only write:
cls.indent(
"Thank you for verifying your email successfully!
There was a problem hiding this comment.
To access the token there should be a function get_token and set_token
There was a problem hiding this comment.
Access token thing is in another PR. should we do all in one instead or keep it separate. usually separate notion boards have separate PRs
tabpfn_client/prompt_agent.py
Outdated
| if status_code == 403: | ||
| # Verify email | ||
| verified = False | ||
| while not verified: |
There was a problem hiding this comment.
Somehow verification is duplicated? Why here and above?
There was a problem hiding this comment.
For registration, Login, and reverification. for login we need to set_token using email and password.
However, i have added a separate function now for verification functionality to avoid this - how about this?
anshulg954
force-pushed
the
hashed_reduced_len_token
branch
from
29bd2de
to
684d11e
Compare
|
Hi, Thanks |
Change Description
Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.
It is an enhancement functionality where we ask user to input the verification token instead of verifying it with a link.
If you used new dependencies: Did you add them to
requirements.txt?Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
@noahho
Breaking changes
If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.
Does this PR break the API? If so, what is the corresponding server commit?
It did not break anything but a few users complained that our emails landed in spam. It is an update where we try to minimize the landing of emails in spam. Corresponding server PR: https://github.com/automl/tabpfn-server/pull/76
Does this PR break the user interface? If so, why?
No, it enhances the user interface.
Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.