Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDM limit max number of future nonces allowed and relayer header backend fix #3380

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

vedhavyas
Copy link
Member

@vedhavyas vedhavyas commented Feb 11, 2025

This PR brings following

  • Add maximum future nonce allowed for a given XDM to 256. So at a time, txpool will include xdms with future nonces to 20 for given domain and channel.
    - Though I left a todo to benchmark and derive a sane number through that bechmarked data
  • Adjust XDM Transaction logenvity to 10 blocks
  • Fix relayer using consensus client as header backend while sending XDM from Domains. This was observed in taurus
  • Do some function parameters renaming for better readability

Note: Will handle #3371 in a different PR

Code contributor checklist:

@vedhavyas vedhavyas added the audit-P2 Medium audit priority label Feb 11, 2025
@vedhavyas vedhavyas requested a review from NingLin-P as a code owner February 11, 2025 05:47
domains/pallets/messenger/src/lib.rs Outdated Show resolved Hide resolved
domains/pallets/messenger/src/lib.rs Outdated Show resolved Hide resolved
@vedhavyas vedhavyas requested a review from NingLin-P February 11, 2025 10:49
@vedhavyas vedhavyas added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@vedhavyas vedhavyas added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 2b2828d Feb 11, 2025
8 checks passed
@vedhavyas vedhavyas deleted the xdm_audit_issue branch February 11, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-P2 Medium audit priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants