Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio_page_per_vq: enhance input event file #5882

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

dzhengfy
Copy link
Contributor

@dzhengfy dzhengfy commented Sep 6, 2024

Regarding /dev/input/event* files, there might be some different situation.
For example,

  • No event file exsit at all
  • Only /dev/input/event0 exists
  • Only /dev/input/event1 exists
  • Both /dev/input/event0 and /dev/input/event1 exists
  • and more ...

So this patch is intending to support above situations instead of hardcoding with event1.

@dzhengfy
Copy link
Contributor Author

dzhengfy commented Sep 6, 2024

Without the fix:

[rhel.virtio_attributes.virtio_page_per_vq.input.passthrough.default_start]
VMStartError: VM 'avocado-vt-vm1' failed to start: error: Failed to start domain 'avocado-vt-vm1'error: Path '/dev/input/event1' is not accessible: No such file or directory(exit status: 1)


Test on arm libvirt-10.5.0-6:

When no event file:
(1/1) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.passthrough.hotplug: CANCEL: ls: cannot access '/dev/input/event*': No such file or directory\n (8.53 s)
RESULTS : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 1
JOB HTML : /var/log/avocado/job-results/job-2024-09-06T05.07-6f4fdfa/results.html
JOB TIME : 9.11 s

When /dev/input/event0 exists:
(1/1) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.passthrough.hotplug: PASS (41.30 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /var/log/avocado/job-results/job-2024-09-06T04.55-1440a9c/results.html
JOB TIME : 41.88 s

(1/1) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.passthrough.default_start: PASS (34.80 s)

Copy link
Contributor

@yafu-1 yafu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloerh
Copy link
Contributor

chloerh commented Sep 20, 2024

Oh, conflicting

Regarding /dev/input/event* files, there might be some different
situation.
For example,
- No event file exsit at all
- Only /dev/input/event0 exists
- Only /dev/input/event1 exists
- Both /dev/input/event0 and /dev/input/event1 exists
- and more ...

So this patch is intending to support above situations instead of
hardcoding with event1.

Signed-off-by: Dan Zheng <[email protected]>
@dzhengfy dzhengfy merged commit 05f452c into autotest:master Dec 3, 2024
5 checks passed
@dzhengfy
Copy link
Contributor Author

dzhengfy commented Dec 3, 2024

Fix conflicts, so merge it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants