Add new image type:vhd/gce support in bootc image builder #5903
+691
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
2 times, most recently
from
6b2cbc5 to
79710d7
Compare
nanli1
reviewed
Sep 23, 2024
Comment on lines
+841
to
+1047
| def convert_vhd_to_qcow2(params): | ||
| """ | ||
| Convert vhd disk format into qcow2 | ||
|
|
||
| @param params: one dictionary wrapping various parameter |
There was a problem hiding this comment.
Missing return converted_image_path instruction here.
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
4 times, most recently
from
f7ab79c to
6e6d4dd
Compare
chunfuwen
changed the title
chunfuwen
changed the title
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
7 times, most recently
from
29cc575 to
d94fc4d
Compare
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
12 times, most recently
from
465b4a4 to
dadcff3
Compare
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
2 times, most recently
from
0461b90 to
a41db25
Compare
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
7 times, most recently
from
6153edd to
101d04e
Compare
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
17 times, most recently
from
3262d4a to
3a0c9c5
Compare
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
2 times, most recently
from
32affb4 to
7f5c47b
Compare
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
2 times, most recently
from
4e182dd to
edce1e8
Compare
vdh and gce are newly introduced support disk image type, and are only supported on upstream Signed-off-by: chunfuwen <[email protected]>
chunfuwen
force-pushed
the
add_vhd_bootc_image_build_case
branch
from
edce1e8 to
cb4821b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new image type:vdh/gce support in bootc image builder
vhd/gce are newly introduced support disk image type, and is only supported on upstream