migrate_options_shared: stabilize auto-converge #6036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example of a lot of dirty pages. |
smitterl
force-pushed
the
stabilize_autoconverge
branch
from
52df01c
to
29c1423
Compare
|
The auto-converge test scenarios are brittle. In order to cause auto-converge to kick in we need to reduce allowed downtime and bandwidth and increase creation of dirty-pages. However, by setting unrealisticly restrictive values we might cause the migration to never converge. Therefore, once auto-converge has kicked in, reset bandwidth and maxdowntime so that the migration can finish more easily. Only help the migration speed up if the auto-converge throttle value has increased once. Furthermore, remove function `run_stress_in_vm` as it's not used anywhere. Instead avocado-vt/virttest/migration/run_stress_in_vm is used. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
stabilize_autoconverge
branch
from
29c1423
to
3aa5cc8
Compare
fangge1212
approved these changes
Dec 4, 2024
cliping
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-converge test scenarios are brittle. In order to cause auto-converge to kick in we need to reduce allowed downtime and bandwidth and increase creation of dirty-pages. However, by setting unrealisticly restrictive values we might cause the migration to never converge. Therefore, once auto-converge has kicked in, reset bandwidth and maxdowntime so that the migration can finish more easily.
Furthermore, remove function
run_stress_in_vmas it's not usedanywhere. Instead
avocado-vt/virttest/migration/run_stress_in_vm is used.