Test the "--managed-save" option #6131
Conversation
|
test results: |
|
|
||
| def vm_undefine_check(vm_name): | ||
| """ | ||
| Check if vm can be undefined with manage-save option |
There was a problem hiding this comment.
it should be managed-save in the above line. Can be ignored as it is in commented block.
There was a problem hiding this comment.
Thank you! updated.
| ignore_status=True) | ||
| LOG.debug("%s", ret1) | ||
| if ret1.exit_status: | ||
| test.fail("Guest can't be undefine with " |
There was a problem hiding this comment.
undefined suits better than undefine
There was a problem hiding this comment.
Thank you! updated.
yalzhang
force-pushed
the
with_option_managed_save
branch
from
29f76f0 to
1772117
Compare
| test.fail("Can't find managed save image") | ||
| LOG.info("Step2: Undefine the VM without --managed-save option:") | ||
| ret = virsh.undefine(vm_name, options='--nvram', ignore_status=True) | ||
| LOG.debug("%s", ret) |
There was a problem hiding this comment.
What about using 'debug=True' in virsh.undefine() instead of logging out it by 'LOG.debug("%s", ret)'? What do you think?
There was a problem hiding this comment.
updated, Thank you!
| if not ret.exit_status: | ||
| test.fail("Guest shouldn't be undefined" | ||
| "while domain managed save image exists!") |
There was a problem hiding this comment.
Would you like to try the result checking wrapper function - libvirt.check_exit_status?
| ret1 = virsh.undefine(vm_name, options="--managed-save --nvram", | ||
| ignore_status=True) | ||
| LOG.debug("%s", ret1) | ||
| if ret1.exit_status: | ||
| test.fail("Guest can't be undefined with " | ||
| "managed-save option!") |
| test.fail("Guest shouldn't be undefined" | ||
| "while domain managed save image exists!") | ||
| LOG.info("Step3: Undefine the VM with --managed-save option:") | ||
| ret1 = virsh.undefine(vm_name, options="--managed-save --nvram", |
There was a problem hiding this comment.
May I ask if '--nvram' option is required? Same question to the first virsh undefine attempt(the failed one) as well.
There was a problem hiding this comment.
For uefi guest, the guest can not be undefined successfully with "--nvram" or "--keep-nvram" option.
The option has no impact for guest with seabios. So I added the "--nvram" to make sure the undefine operation is not blocked by the nvram file.
When the VM have a managedsave file, it can not be undefined without the "--managed-save" option. This option can remove the managedsave file and then undefine the VM. Signed-off-by: Yalan Zhang <[email protected]>
yalzhang
force-pushed
the
with_option_managed_save
branch
from
1772117 to
40d7b9b
Compare
When the VM have a managedsave file, it can not be undefined without the "--managed-save" option. This option can remove the managedsave file and then undefine the VM. (automate VIRT-297771)