Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(autoware_integration): integration guide improvements #469

Closed

Conversation

danielsanchezaran
Copy link

@danielsanchezaran danielsanchezaran commented Oct 18, 2023

Description

This is a set of (ongoing) recommendations and improvements to the Autoware integration guide based on my own experience integrating Autoware on a robotized vehicle. I believe these changes might make it easier for a new user to use Autoware on their vehicle.

The changes include:
-Improved description of a meta-repository and how to set an autoware meta-repo.
-Clearer explanation of the sample_repository-sample_package relationship and structure.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@danielsanchezaran danielsanchezaran added the type:documentation Creating or refining documentation. label Oct 18, 2023
@danielsanchezaran danielsanchezaran self-assigned this Oct 18, 2023
@danielsanchezaran danielsanchezaran changed the title Documentation/integration guide improvements docs(autoware_integration): integration guide improvements Oct 18, 2023
Signed-off-by: Daniel Sanchez <[email protected]>
@ismetatabay
Copy link
Member

@danielsanchezaran Hi,

Also I am working on similar topic, could you look at these PRs?

Creating meta repositories:

Creating vehicle and sensor model - individual params:

Sensor calibration:

Creating vehicle interface:

Creating map:

Also, I am currently working on:

@danielsanchezaran
Copy link
Author

@danielsanchezaran Hi,

Also I am working on similar topic, could you look at these PRs?

Creating meta repositories:

Creating vehicle and sensor model - individual params:

Sensor calibration:

Creating vehicle interface:

Creating map:

Also, I am currently working on:

Thank you very much for pointing me to those PRs lets try to combine improvements on the same topics.

@shmpwk shmpwk added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Oct 18, 2023
@danielsanchezaran
Copy link
Author

Since most of my updates are already included in Ismet's PRs I will be closing this PR draft

@kminoda kminoda deleted the documentation/integration-guide-improvements branch November 7, 2023 23:38
@kminoda kminoda restored the documentation/integration-guide-improvements branch November 7, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants