Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add lidar imu calibration #483

Merged

Conversation

StepTurtle
Copy link
Contributor

Description

Added lidar imu calibration instructions.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
@StepTurtle StepTurtle added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 17, 2023
Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay force-pushed the bz/dev/lidar-imu-calibration branch from 8792adf to aae71cd Compare November 17, 2023 14:07
Signed-off-by: Barış Zeren <[email protected]>
…utoware-documentation into bz/dev/lidar-imu-calibration
Signed-off-by: Barış Zeren <[email protected]>
@ismetatabay
Copy link
Member

Hi @StepTurtle, thanks for the PR, it has been a step by step explanation page. @yvzksgl can perform the calibration process with the following these steps.

Can you sign the following commit: ca2bef7 After that I can approve this PR, thanks!

@ismetatabay ismetatabay force-pushed the bz/dev/lidar-imu-calibration branch 7 times, most recently from 22c0a71 to fe24ef5 Compare December 26, 2023 11:16
Signed-off-by: Barış Zeren <[email protected]>
@ismetatabay ismetatabay force-pushed the bz/dev/lidar-imu-calibration branch from fe24ef5 to 80043d1 Compare December 26, 2023 11:17
Copy link
Member

@ismetatabay ismetatabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StepTurtle StepTurtle merged commit 712121a into autowarefoundation:main Jan 2, 2024
8 of 9 checks passed
@StepTurtle StepTurtle deleted the bz/dev/lidar-imu-calibration branch January 2, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants