-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix localization's input pointcloud #491
Merged
YamatoAndo
merged 12 commits into
autowarefoundation:main
from
YamatoAndo:fix/localization_input_pointcloud
Dec 8, 2023
Merged
docs: fix localization's input pointcloud #491
YamatoAndo
merged 12 commits into
autowarefoundation:main
from
YamatoAndo:fix/localization_input_pointcloud
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
mitsudome-r
added
the
tag:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
label
Nov 30, 2023
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
4 tasks
This was referenced Dec 5, 2023
Merged
isamu-takagi
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's almost good, but it is better to write "T.B.D." for the empty topic names.
@isamu-takagi Thank you for the comment. I have modified it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are cases where a point cloud integrating multiple LiDARs is used as input to localization, and there are also cases where a single LiDAR is used.
Therefore, I have modified the
design/autoware-interface/componets/sensing.md
.Additionally, I have corrected the topic name of the input point cloud in the node diagram for localization to match the current state (
/sensing/lidar/pointcloud
->/sensing/lidar/top/pointcloud
).Related PRs
Merge all Related PRs at the same time.
#491
autowarefoundation/autoware.universe#5781
autowarefoundation/sample_sensor_kit_launch#82
autowarefoundation/autoware_launch#722
tier4/awsim_sensor_kit_launch#12
autowarefoundation/awf_reference_sensor_kit_launch#7
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.