Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update diagram related to ground_segmentation #527

Merged

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Mar 4, 2024

Description

Related Link

TIER IV INTERNAL LINK

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen badai-nguyen requested review from miursh and kminoda March 4, 2024 04:52
Signed-off-by: badai-nguyen <[email protected]>
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR 🙏

Signed-off-by: badai-nguyen <[email protected]>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]
Could you remove this line jump here?
image

Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen
Copy link
Contributor Author

[nits] Could you remove this line jump here? image

@miursh I fixed here 15d8426
image

@badai-nguyen badai-nguyen merged commit 22528bf into autowarefoundation:main Mar 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants