feat(ad-api): manual control #631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
isamu-takagi
requested review from
youtalk,
yukkysaito,
sasakisasaki and
mitsudome-r
Signed-off-by: Takagi, Isamu <[email protected]>
isamu-takagi
added
the
tag:deploy-docs
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 27 out of 42 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- docs/design/autoware-interfaces/ad-api/list/api/local/command/steering.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/local/control_mode/select.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/index.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/remote/command/acceleration.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/remote/command/steering.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/local/command/pedal.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/remote/command/pedal.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/local/command/acceleration.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/remote/command/hazard_lights.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/local/operator/status.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/remote/control_mode/list.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/local/control_mode/status.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/remote/command/gear.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/local/control_mode/list.md: Evaluated as low risk
- docs/design/autoware-interfaces/ad-api/list/api/remote/control_mode/select.md: Evaluated as low risk
Comments skipped due to low confidence (2)
docs/design/autoware-interfaces/ad-api/features/manual-control.md:45
- [nitpick] The term 'pedal' might be ambiguous. It should be renamed to 'pedal_control' for clarity.
| pedal | This mode provides longitudinal control using the pedals. |
docs/design/autoware-interfaces/ad-api/list/api/local/command/hazard_lights.md:11
- The term 'status' is vague. It should specify whether the hazard lights are on or off. Consider changing it to 'Target hazard lights state (on/off)'.
text: Target hazard lights status.
Signed-off-by: Takagi, Isamu <[email protected]>
sasakisasaki
reviewed
Dec 6, 2024
docs/design/autoware-interfaces/ad-api/features/manual-control.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Takagi, Isamu <[email protected]>
mitsudome-r
reviewed
Dec 23, 2024
Comment on lines
+57
to
+59
| | pedal | - | ✓ | - | - | | ||
| | acceleration | - | - | ✓ | - | | ||
| | velocity | - | - | - | ✓ | |
There was a problem hiding this comment.
What happens if the user tries to select a mode (e.g., acceleration) and if that mode isn't supported from by the vehicle. Would the API just return the fail as a response status?
There was a problem hiding this comment.
Yes, if the control mode is not supported, the select API will fail and the command APIs will not be enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add manual control API.
https://github.com/orgs/autowarefoundation/discussions/5369
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.