Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ad-api): drop allow_while_using_route option #633

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Dec 10, 2024

Description

Drop allow_while_using_route option. The restrictions added to clear_route make the same check as this option, so it is thought that it can be substituted with clear_route and set_route. We will reconsider whether chante_route needs an option.

Related: autowarefoundation/autoware_adapi_msgs#71

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 10, 2024
@isamu-takagi isamu-takagi merged commit 0f10c35 into autowarefoundation:main Dec 11, 2024
14 checks passed
@isamu-takagi isamu-takagi deleted the feat/drop-allow-while-using-route-option branch December 11, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants