-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clang-tidy): introducing .clang-tidy-ignore #326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veqcc
reviewed
Nov 28, 2024
veqcc
reviewed
Nov 28, 2024
veqcc
reviewed
Nov 28, 2024
veqcc
reviewed
Nov 28, 2024
veqcc
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Please move on to @.xmfcx & @.mitsudome-r reviews.
Signed-off-by: Y.Hisaki <[email protected]>
yhisaki
force-pushed
the
enhance-clang-tidy
branch
from
November 28, 2024 06:56
a65eb5e
to
8db85fd
Compare
mitsudome-r
reviewed
Nov 28, 2024
Signed-off-by: Y.Hisaki <[email protected]>
mitsudome-r
approved these changes
Nov 28, 2024
Signed-off-by: Y.Hisaki <[email protected]>
xmfcx
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for ignoring specific files in
clang-tidy
.To achieve this, you can create a
.clang-tidy-ignore
file under your project directory and list file paths or regular expressions for the files you wish to ignore, as shown below:Additionally, this PR includes minor changes.
Use
run-clang-tidy
instead ofclang-tidy
.run-clang-tidy
allows for parallel execution ofclang-tidy
.Change the report file suffix from
.txt
to.log
.Related links
Tests performed
Tested in this Action.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.