Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(words): add deregistering #10

Merged
merged 2 commits into from
Dec 4, 2024
Merged

feat(words): add deregistering #10

merged 2 commits into from
Dec 4, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 4, 2024

Description

Related links

Parent Issue/PR:

Warning: Unknown word (Deregistering)
common/autoware_control_center/src/control_center_node.cpp:122:37 Unknown word (Deregistering)

Links to the definitions of the words added:

Notes for reviewers

My usage started with a capital letter. But added to the dictionary with all small letters. I wonder if it will recognize, let's test.

Copy link

github-actions bot commented Dec 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx self-assigned this Dec 4, 2024
@xmfcx xmfcx marked this pull request as ready for review December 4, 2024 21:39
@xmfcx xmfcx requested a review from mitsudome-r as a code owner December 4, 2024 21:39
@mitsudome-r mitsudome-r merged commit 82bc55c into main Dec 4, 2024
9 checks passed
@mitsudome-r mitsudome-r deleted the feat/deregister branch December 4, 2024 22:07
@xmfcx
Copy link
Contributor Author

xmfcx commented Dec 4, 2024

Thanks, it was fixed:

It seems to not care about the capitalization ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants