-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ekf_localizer): increase z_filter_proc_dev for large gradient road #211
chore(ekf_localizer): increase z_filter_proc_dev for large gradient road #211
Conversation
Signed-off-by: Kento Yabuuchi <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SakodaShintaro Thank you for testing! 😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
===========================================
- Coverage 78.75% 51.07% -27.69%
===========================================
Files 11 35 +24
Lines 193 1627 +1434
Branches 73 609 +536
===========================================
+ Hits 152 831 +679
- Misses 11 648 +637
- Partials 30 148 +118
☔ View full report in Codecov by Sentry. |
Description
I think the current
z_filter_proc_dev
is too small, so I propose increasing it.Recently, I encountered an issue where localization failed in tunnel with a gradient.
In areas with a steep gradient, even if NDT scan matching outputs a correct pose, the 1D filter in the EKF localizer suppresses the variation in the altitude position. And the suppression lead to the NDT's mis-matching.
In the tunnel data I tested, this change prevented localization failure, and I did not observe any performance degradation in other environments.
The gradient of the undersea tunnel I verified had a gradient of 60m down at 600m. 📉
Related links
TIER IV internal link (localization failure in undersee tunnel)
TIER IV internal link (Impact verification outside the tunnel)
How was this PR tested?
Notes for reviewers
autoware_launch PR: autowarefoundation/autoware_launch#1337
Interface changes
None.
Effects on system behavior
None.