Skip to content

Commit

Permalink
refactor: rename parameter to avoid failure of spell-check
Browse files Browse the repository at this point in the history
Signed-off-by: ktro2828 <[email protected]>
  • Loading branch information
ktro2828 committed Oct 11, 2023
1 parent 69560e1 commit 4baa9e2
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
match_threshold_ms: 50.0
image_buffer_size: 15
debug_mode: false
filter_scope_minx: -100.0
filter_scope_miny: -100.0
filter_scope_minz: -100.0
filter_scope_maxx: 100.0
filter_scope_maxy: 100.0
filter_scope_maxz: 100.0
filter_scope_min_x: -100.0
filter_scope_min_y: -100.0
filter_scope_min_z: -100.0
filter_scope_max_x: 100.0
filter_scope_max_y: 100.0
filter_scope_max_z: 100.0
Original file line number Diff line number Diff line change
Expand Up @@ -36,32 +36,32 @@
"description": "Whether to debug or not.",
"default": false
},
"filter_scope_minx": {
"filter_scope_min_x": {
"type": "number",
"description": "Minimum x position to be considered for debug [m].",
"default": -100.0
},
"filter_scope_miny": {
"filter_scope_min_y": {
"type": "number",
"description": "Minimum y position to be considered for debug [m].",
"default": -100.0
},
"filter_scope_minz": {
"filter_scope_min_z": {
"type": "number",
"description": "Minimum z position to be considered for debug [m].",
"default": -100.0
},
"filter_scope_maxx": {
"filter_scope_max_x": {
"type": "number",
"description": "Maximum x position to be considered for debug [m].",
"default": 100.0
},
"filter_scope_maxy": {
"filter_scope_max_y": {
"type": "number",
"description": "Maximum y position to be considered for debug [m].",
"default": 100.0
},
"filter_scope_maxz": {
"filter_scope_max_z": {
"type": "number",
"description": "Maximum z position [m].",
"default": 100.0
Expand Down
12 changes: 6 additions & 6 deletions perception/image_projection_based_fusion/src/fusion_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,12 @@ FusionNode<Msg, ObjType>::FusionNode(

// cspell: ignore minx, maxx, miny, maxy, minz, maxz
// FIXME: use min_x instead of minx
filter_scope_minx_ = declare_parameter<double>("filter_scope_minx");
filter_scope_maxx_ = declare_parameter<double>("filter_scope_maxx");
filter_scope_miny_ = declare_parameter<double>("filter_scope_miny");
filter_scope_maxy_ = declare_parameter<double>("filter_scope_maxy");
filter_scope_minz_ = declare_parameter<double>("filter_scope_minz");
filter_scope_maxz_ = declare_parameter<double>("filter_scope_maxz");
filter_scope_minx_ = declare_parameter<double>("filter_scope_min_x");
filter_scope_maxx_ = declare_parameter<double>("filter_scope_max_x");
filter_scope_miny_ = declare_parameter<double>("filter_scope_min_y");
filter_scope_maxy_ = declare_parameter<double>("filter_scope_max_y");
filter_scope_minz_ = declare_parameter<double>("filter_scope_min_z");
filter_scope_maxz_ = declare_parameter<double>("filter_scope_max_z");

Check warning on line 147 in perception/image_projection_based_fusion/src/fusion_node.cpp

View check run for this annotation

Codecov / codecov/patch

perception/image_projection_based_fusion/src/fusion_node.cpp#L142-L147

Added lines #L142 - L147 were not covered by tests
}

template <class Msg, class Obj>
Expand Down

0 comments on commit 4baa9e2

Please sign in to comment.