Skip to content

Commit

Permalink
refactor: add configuration file and update launcher to load this
Browse files Browse the repository at this point in the history
Signed-off-by: ktro2828 <[email protected]>
  • Loading branch information
ktro2828 committed Sep 6, 2023
1 parent 6f56cff commit dede75c
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 17 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/**:
ros__parameters:
use_iou: true
use_iou_x: false
use_iou_y: false
use_cluster_semantic_type: false
only_allow_inside_cluster: true
roi_scale_factor: 1.1
iou_threshold: 0.35
unknown_iou_threshold: 0.1
remove_unknown: false
trust_distance: 100.0
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@
<node pkg="image_projection_based_fusion" exec="pointpainting_fusion_node" name="pointpainting" output="screen">
<remap from="~/input/pointcloud" to="$(var input/pointcloud)"/>
<remap from="~/output/objects" to="$(var output/objects)"/>
<param name="score_threshold" value="0.35"/>
<param name="densification_world_frame_id" value="map"/>
<param name="densification_num_past_frames" value="1"/>
<param name="trt_precision" value="fp16"/>
<param name="encoder_onnx_path" value="$(var model_path)/pts_voxel_encoder_$(var model_name).onnx"/>
<param name="encoder_engine_path" value="$(var model_path)/pts_voxel_encoder_$(var model_name).engine"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
<arg name="input/camera_info7" default="/camera_info7"/>
<arg name="input/clusters" default="clusters"/>
<arg name="output/clusters" default="labeled_clusters"/>
<arg name="param_path" default="$(find-pkg-share image_projection_based_fusion)/config/roi_cluster_fusion.param.yaml"/>
<arg name="sync_param_path" default="$(find-pkg-share image_projection_based_fusion)/config/roi_sync.param.yaml"/>
<arg name="remove_unknown" default="true"/>
<arg name="trust_distance" default="100.0"/>

<!-- for eval variable-->
<arg name="input_rois_number" default="$(var input/rois_number)"/>
Expand All @@ -45,16 +44,8 @@
<arg name="input/image7" default="/image_raw7"/>
<group>
<node pkg="image_projection_based_fusion" exec="roi_cluster_fusion_node" name="roi_cluster_fusion" output="screen">
<param name="use_iou" value="true"/>
<param name="use_iou_x" value="false"/>
<param name="use_iou_y" value="false"/>
<param name="only_allow_inside_cluster" value="true"/>
<param name="roi_scale_factor" value="1.1"/>
<param name="iou_threshold" value="0.35"/>
<param name="unknown_iou_threshold" value="0.1"/>
<param name="rois_number" value="$(var input/rois_number)"/>
<param name="remove_unknown" value="$(var remove_unknown)"/>
<param name="trust_distance" value="$(var trust_distance)"/>
<param from="$(var param_path)"/>
<param from="$(var sync_param_path)"/>
<remap from="input" to="$(var input/clusters)"/>
<remap from="output" to="$(var output/clusters)"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
"use_iou": {
"type": "boolean",
"description": "If this parameter is true, calculate the common IoU score.",
"default": false
"default": true
},
"use_iou_x": {
"type": "boolean",
"description": "If this parameter is true, compute the IoU score in the x-direction",
"default": true
"default": false
},
"use_iou_y": {
"type": "boolean",
Expand All @@ -41,7 +41,7 @@
"iou_threshold": {
"type": "number",
"description": "An IoU score threshold. Note that the total IoU score is the sum of the IoU scores that are set to true in use_iou, use_iou_x and use_iou_y.",
"default": 0.3,
"default": 0.35,
"minimum": 0.0
},
"unknown_iou_threshold": {
Expand Down

0 comments on commit dede75c

Please sign in to comment.