update with the reviewers comments

Signed-off-by: Yuki Takagi <[email protected]>
autowarefoundation · Jan 31, 2024 · ea803bb · ea803bb
1 parent 9096bec
commit ea803bb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/perception/map_based_prediction/include/map_based_prediction/map_based_prediction_node.hpp b/perception/map_based_prediction/include/map_based_prediction/map_based_prediction_node.hpp
@@ -137,7 +137,7 @@ class MapBasedPredictionNode : public rclcpp::Node
   std::shared_ptr<lanelet::routing::RoutingGraph> routing_graph_ptr_;
   std::shared_ptr<lanelet::traffic_rules::TrafficRules> traffic_rules_ptr_;
 
-  std::unordered_map<lanelet::Id, TrafficSignal> traffic_signal_id_map;
+  std::unordered_map<lanelet::Id, TrafficSignal> traffic_signal_id_map_;
 
   // parameter update
   OnSetParametersCallbackHandle::SharedPtr set_param_res_;

diff --git a/perception/map_based_prediction/src/map_based_prediction_node.cpp b/perception/map_based_prediction/src/map_based_prediction_node.cpp
@@ -877,9 +877,9 @@ void MapBasedPredictionNode::mapCallback(const HADMapBin::ConstSharedPtr msg)
 
 void MapBasedPredictionNode::trafficSignalsCallback(const TrafficSignalArray::ConstSharedPtr msg)
 {
-  traffic_signal_id_map.clear();
+  traffic_signal_id_map_.clear();
   for (const auto & signal : msg->signals) {
-    traffic_signal_id_map[signal.traffic_signal_id] = signal;
+    traffic_signal_id_map_[signal.traffic_signal_id] = signal;
   }
 }
 
@@ -1232,18 +1232,17 @@ PredictedObject MapBasedPredictionNode::getPredictedObjectAsCrosswalkUser(
     const auto crosswalk_signal_id_opt = getTrafficSignalId(crosswalk);
     if (crosswalk_signal_id_opt.has_value()) {
       // If the crosswalk has traffic light, do something.
-      if (traffic_signal_id_map.count(crosswalk_signal_id_opt.value()) != 0) {
+      if (traffic_signal_id_map_.count(crosswalk_signal_id_opt.value()) != 0) {
         const auto & signal_elements =
-          traffic_signal_id_map.at(crosswalk_signal_id_opt.value()).elements;
+          traffic_signal_id_map_.at(crosswalk_signal_id_opt.value()).elements;
         if (signal_elements.size() > 1) {
           RCLCPP_ERROR(
-            get_logger(), "[Map Based Prediction]: Multiple TrafficSignalElement_ are recieved.");
+            get_logger(), "[Map Based Prediction]: Multiple TrafficSignalElement_ are received.");
         } else if (
           !signal_elements.empty() && signal_elements.front().color == TrafficSignalElement::RED) {
           continue;
         }
       }
-      // TODO(yuki takagi): If a flag is setted, wait for timeout while the pedestrian is stopping.
     }
 
     const auto edge_points = getCrosswalkEdgePoints(crosswalk);
@@ -2252,7 +2251,6 @@ std::optional<lanelet::Id> MapBasedPredictionNode::getTrafficSignalId(
       get_logger(),
       "[Map Based Prediction]: "
       "Multiple regulatory elements as TrafficLight are defined to one lanelet object.");
-    return std::nullopt;  // Is it appropriate?
   }
   return traffic_light_reg_elems.front()->id();
 }