Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timing_violation_monitor node #3049

Open
3 tasks done
nabetetsu opened this issue Mar 10, 2023 · 2 comments
Open
3 tasks done

Add timing_violation_monitor node #3049

nabetetsu opened this issue Mar 10, 2023 · 2 comments
Assignees
Labels
priority:high High urgency and importance. status:help-wanted Assistance or contributors needed. status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@nabetetsu
Copy link

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Currently, there is no common mechanism for detecting timing violation. Autoware is a real-time system, which means that the software shall save time constraints and use more fresh data. If time constraints cannot be saved, any function failed, and it may be difficult to continue the service.
For example, Localization is one of the critical features of Autoware, and it has time constraints.

I'd like to add a feature to monitor the timing violation of the time constraints and report it through /diagnostics by debugging purpose.

This issue is created from the following discussion.
https://github.com/orgs/autowarefoundation/discussions/3176

We have not reached a consensus yet in the discussion, but after internal discussion, I would like to add this feature for debugging purposes. Since it is for debugging purposes, changes to this feature shold be as easy as possible to revert.

Purpose

For debugging purposes, the response time of a given path is monitored and the result of a timing violation is reported.

In the future, I will plan to implement a feature that detects the possibility of deadline violations early and notifies the necessary nodes.

Possible approaches

1: To introduce a timing_violation_monitor node
2: To introduce a timing violation detection function at an end node of a path
3: To extend topic_state_monitor to support timing violation detection
4: ros2 topic delay

Definition of done

  • User can check the results by rqt_runtime_monitor
  • User can check the results by FSM
@nabetetsu
Copy link
Author

nabetetsu commented Mar 10, 2023

possible approaches #1:
#2983
tier4/tier4_autoware_msgs#75

@BonoloAWF BonoloAWF added type:new-feature New functionalities or additions, feature requests. status:help-wanted Assistance or contributors needed. priority:high High urgency and importance. labels Mar 21, 2023
@stale
Copy link

stale bot commented May 20, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High urgency and importance. status:help-wanted Assistance or contributors needed. status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants