-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(timing violation monitor): add timing violation monitor node #2983
feat(timing violation monitor): add timing violation monitor node #2983
Conversation
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
…ory) Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
…tation Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
…sts.txt Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Co-authored-by: Takayuki AKAMINE <[email protected]>
Based on internal discussions, the localization change will be removed in this PR to allow only the timing violation monitor functionality to be added. |
…e localization changes from PR Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
How does this relate to https://github.com/tier4/TILDE? |
This pull request has been automatically marked as stale because it has not had recent activity. |
@nabetetsu @takam5f2 We are also considering to add monitored subscribers to Autoware Core. Is this relevant to this PR? |
Thank you for the suggestion. It seemed that the similar function is introduced via #6547. monitored subscribers to Autoware Core looks interesting to me. I think that node should check how old the received data is by itself. Anyway, I'd like to close this PR. |
Description
Closes: #3049
This PR contains
timing_violation_monitor
node implementation.Timing violation means the event when response time is larger than expected.For more information on timing_violation_moinitor, please see the Discussion thread.
We are considering the
localization
as a first step for monitored using this feature. This PR will mainly add the subscribing and monitoring side, the sender side is implemented in another PR.timing_violation_monitor
notifies/diagnostics
at specified intervals whether or not the deadline miss has occurred.All messages used by
timing_violation_monitor
will be added intier4_autoware_msgs
by this PR.The following overview diagram of the operation of
timing_violation_monitor
shows the areas of focus in this PR.Related links
Discussion thread
Sender implementation
Add new messages
Tests performed
timing_violation_monitor
:Notes for reviewers
timing_violation_monitor
is need to launch directly at this moment.ex:
ros2 launch timing_violation_monitor timing_violation_monitor_node.launch.xml
Please let me discuss how it should be launched in the meetings.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.