Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component_interface_utils): change service log output #2022

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Oct 5, 2022

Description

Change service log output from console to topic. Related to tier4/tier4_autoware_msgs#58.
Trying to replay a service from rosbag for AD API debugging.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi force-pushed the feature/logging-component-interface-utils branch from b1eef55 to 7024929 Compare October 5, 2022 06:14
@isamu-takagi isamu-takagi marked this pull request as ready for review October 5, 2022 06:17
@kenji-miyake
Copy link
Contributor

Trying to replay a service from rosbag for AD API debugging.

Related: ros2/rosbag2#773 (comment)

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 10.41% // Head: 10.41% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d20a94a) compared to base (7372109).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2022      +/-   ##
==========================================
- Coverage   10.41%   10.41%   -0.01%     
==========================================
  Files        1170     1170              
  Lines       83556    83564       +8     
  Branches    19568    19569       +1     
==========================================
  Hits         8705     8705              
- Misses      65345    65353       +8     
  Partials     9506     9506              
Flag Coverage Δ *Carryforward flag
differential 13.90% <ø> (?)
total 10.40% <ø> (ø) Carriedforward from 7372109

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
system/default_ad_api/src/interface.cpp 62.50% <0.00%> (-8.93%) ⬇️
system/default_ad_api/src/localization.cpp 37.50% <0.00%> (-5.36%) ⬇️
system/default_ad_api/src/routing.cpp 33.33% <0.00%> (-4.17%) ⬇️
control/vehicle_cmd_gate/src/pause_interface.cpp 0.00% <0.00%> (ø)
...pi_helpers/ad_api_adaptors/src/routing_adaptor.cpp 0.00% <0.00%> (ø)
...lpers/ad_api_adaptors/src/initial_pose_adaptor.cpp 0.00% <0.00%> (ø)
...zer/src/pose_initializer/pose_initializer_core.cpp 0.00% <0.00%> (ø)
...ose_initializer/src/automatic_pose_initializer.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi isamu-takagi enabled auto-merge (squash) October 13, 2022 09:19
@isamu-takagi isamu-takagi merged commit 0f16c2b into autowarefoundation:main Oct 13, 2022
@isamu-takagi isamu-takagi deleted the feature/logging-component-interface-utils branch October 13, 2022 09:32
scepter914 pushed a commit to scepter914/autoware.universe that referenced this pull request Nov 1, 2022
…oundation#2022)

* feat(component_interface_utils): change client log

Signed-off-by: Takagi, Isamu <[email protected]>

* feat(component_interface_utils): change server log

Signed-off-by: Takagi, Isamu <[email protected]>

* feat(component_interface_utils): add interface

Signed-off-by: Takagi, Isamu <[email protected]>

* feat: add console log

Signed-off-by: Takagi, Isamu <[email protected]>

Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: scepter914 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants