feat(timing_violation_monitor): add timing violation monitor node which monitoring response time of Path #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
…ory) Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
…tation Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
…sts.txt Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
github-actions
bot
added
type:documentation
nabetetsu
changed the title
…e intersection (autowarefoundation#2862) * fix(behavior_path_planner): deal with edge case of drivable area expansion Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
…ency (autowarefoundation#2869) Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
…utowarefoundation#2908) * Performance tuning Signed-off-by: Takahiro Ishikawa <[email protected]> * style(pre-commit): autofix * Deal with cyclomatic complexity * style(pre-commit): autofix * Deal with cyclomatic complexity Signed-off-by: Takahiro Ishikawa <[email protected]> * style(pre-commit): autofix * Fix Signed-off-by: Takahiro Ishikawa <[email protected]> * Fix Signed-off-by: Takahiro Ishikawa <[email protected]> * style(pre-commit): autofix * Add TODO comment Signed-off-by: Takahiro Ishikawa <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Takahiro Ishikawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oundation#2917) Signed-off-by: Esteve Fernandez <[email protected]>
…efoundation#2937) Signed-off-by: Esteve Fernandez <[email protected]>
…utowarefoundation#2558) * extend trajectory along vehicle length Signed-off-by: ismetatabay <[email protected]> * fix parameter type Signed-off-by: ismetatabay <[email protected]> * add default value Signed-off-by: ismetatabay <[email protected]> * ci(pre-commit): autofix Signed-off-by: ismetatabay <[email protected]> * update readme. Signed-off-by: ismetatabay <[email protected]> * ci(pre-commit): autofix Signed-off-by: ismetatabay <[email protected]> * update checking condition Signed-off-by: ismetatabay <[email protected]> * update README.md Signed-off-by: ismetatabay <[email protected]> * style(pre-commit): autofix Signed-off-by: ismetatabay <[email protected]> * remove default parameter value Signed-off-by: ismetatabay <[email protected]> --------- Signed-off-by: ismetatabay <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…efoundation#2934) delete param Signed-off-by: yamazakiTasuku <[email protected]> Co-authored-by: yamazakiTasuku <[email protected]>
* chore(control_performance_analysis): add maintainers Signed-off-by: satoshi-ota <[email protected]> * chore(external_cmd_selector): add maintainers Signed-off-by: satoshi-ota <[email protected]> * chore(joy_controller): add maintainers Signed-off-by: satoshi-ota <[email protected]> * chore(obstacle_collision_checker): add maintainers Signed-off-by: satoshi-ota <[email protected]> * chore(scenariio_selector): add maintainers Signed-off-by: satoshi-ota <[email protected]> * fix(control_performance_analysis): control/control_performance_analysis/package.xml Co-authored-by: Kenji Miyake <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: Kenji Miyake <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: satoshi-ota <[email protected]>
delte param Signed-off-by: yamazakiTasuku <[email protected]> Co-authored-by: yamazakiTasuku <[email protected]>
…foundation#2945) delete param Signed-off-by: yamazakiTasuku <[email protected]> Co-authored-by: yamazakiTasuku <[email protected]>
…refoundation#2944) delete param Signed-off-by: yamazakiTasuku <[email protected]> Co-authored-by: yamazakiTasuku <[email protected]>
…undation#2949) * fix(avoidance): output stop point inserted reference path Signed-off-by: satoshi-ota <[email protected]> * fix(behavior_path_planner): keep avoidance input points Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
) delete param Signed-off-by: yamazakiTasuku <[email protected]> Co-authored-by: yamazakiTasuku <[email protected]>
…undation#2935) * delete param Signed-off-by: yamazakiTasuku <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: yamazakiTasuku <[email protected]> Co-authored-by: yamazakiTasuku <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…on#2953) * feat(obstacle_stop_planner): add margin behind goal Signed-off-by: kosuke55 <[email protected]> * refactor: just compare end index Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]>
…ion#2839) * fix(lane_change): improvement on isLaneChangePathSafe computation Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * re-add logic to ignore parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix the duration issues and some code editing Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…#2956) * docs(behavior_path_planner): align document title Signed-off-by: satoshi-ota <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… point (autowarefoundation#2955) * feat(motion_velocity_smoother): remove unnecessary constant value Signed-off-by: yutaka <[email protected]> * update Signed-off-by: yutaka <[email protected]> --------- Signed-off-by: yutaka <[email protected]>
…r tree (autowarefoundation#2919) * feat(data_manager): add member variable for new framework Signed-off-by: satoshi-ota <[email protected]> * feat(utilities): add util function Signed-off-by: satoshi-ota <[email protected]> * feat(behavior_path_planner): add framework that based on new architecture Signed-off-by: satoshi-ota <[email protected]> * fix(behavior_path_planner): changeable framework by macro Signed-off-by: satoshi-ota <[email protected]> * feat(behavior_path_planner): change framework in cmake Signed-off-by: satoshi-ota <[email protected]> * fix(behavior_path_planner): fix cmake lint error Signed-off-by: satoshi-ota <[email protected]> * fix(planner_manager): rename functions Signed-off-by: satoshi-ota <[email protected]> * fix(planner_manager): not use ModuleID Signed-off-by: satoshi-ota <[email protected]> * refactor(planner_manager): use lambda Signed-off-by: satoshi-ota <[email protected]> * feat(planner_manager): reserve vector Signed-off-by: satoshi-ota <[email protected]> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <[email protected]> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <[email protected]> * fix(behavior_path_planner): fix copyright Co-authored-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: Zulfaqar Azmi <[email protected]>
…dation#2796) * update obstacle avoidance planner, static centerline optimizer, tier4_planning_launch Signed-off-by: Takayuki Murooka <[email protected]> * update velocity on joint and correct trajectory z Signed-off-by: Takayuki Murooka <[email protected]> * update Signed-off-by: Takayuki Murooka <[email protected]> * minor change Signed-off-by: Takayuki Murooka <[email protected]> * pre-commit Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
github-actions
bot
added
type:ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to add a new timing violation monitoring feature to the
Localizationof Autoware.universe. Timing violation means the event when response time is larger than expected.For more information on
timing_violation_moinitor, please see the Discussion thread.As mentioned in the Discussion thread above, the timestamp value contained in topic is important for monitoring response time with
timing_violation_monitor. As explained in the "Precondition on timestamp" section of the Discussion thread, if the end of the path is publishing an existing topic, thentiming_violation_monitorwill receive that topic nad use timestamp included in the topic. By using an existing topic, there is no implementation changes to the existing node implementation.On the other hand, if the timestamp passed from the start node is not output at the end of node, it is necessary to send a dedicated message.
In this PR,
system/timing_violation_monitorlibrary is added to provide a function to send a dedicated message, which will be used inndt_scan_matcher.This PR focuses on the impact on existing code that may be caused by the introduction of the
system/timing_violation_monitormechanism. Therefore, this PR does not include the core implementation oftiming_violation_monitornode. Since subscriber does not exist at this moment, so it has no operational impact.The dedicated message is added in
tier4_autoware_msgsby this PR.I will create another PR for
timing_violation_monitornode implementation.The following overview diagram of the operation of timing_violation_monitor shows the areas of focus in this PR.
Changes
Related links
Discussion thread
Tests performed
There is no operational impact from this PR at all.
The PR of the
timing_violation_monitor nodeitself presents the test results.Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.