ci(pre-commit): add check-jsonschema #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it to validate the JSON Schema files against their meta-schema. Issue-Id: SCM-6366 Signed-off-by: Ambroise Vincent <[email protected]> Change-Id: I4b4990972ef7da9b4bfe33dc350fc157a27a47bb
kenji-miyake
changed the title
3 tasks
kenji-miyake
approved these changes
Jun 16, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use check-jsonschema from https://github.com/python-jsonschema/check-jsonschema to validate the JSON Schema files against their meta-schema. It is a CLI wrapper around the python library from https://github.com/python-jsonschema/jsonschema/
Relates to autowarefoundation/autoware-github-actions#232
Tests performed
Ran pre-commit locally on both a compliant and non-compliant .json schema file (currently only a single file under perception/lidar_apollo_segmentation_tvm_nodes/schema/lidar_apollo_segmentation_tvm_nodes.schema.json).
Effects on system behavior
Fails pre-commit if a schema file does not respect its meta-schema format.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.