Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(behavior_path_planner): define class of SafetyChaecker #4018

Closed
wants to merge 31 commits into from
Closed

feat(behavior_path_planner): define class of SafetyChaecker #4018

wants to merge 31 commits into from

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara
temp
8cf1d9e 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
Merge branch 'main' into feat/safety_checker_class
6c5c1c9 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
temp
fdc6a5c 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
Merge branch 'main' into feat/safety_checker_class
b5c4f9d 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
Squashed commit of the following:
bf08a58 
commit 3dcfb6e
Author: kyoichi-sugahara <[email protected]>
Date:   Tue Jun 13 14:41:19 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit eeb884c
Author: kyoichi-sugahara <[email protected]>
Date:   Tue Jun 13 14:13:34 2023 +0900

    refactoring

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 50e8346
Author: kyoichi-sugahara <[email protected]>
Date:   Tue Jun 13 13:50:49 2023 +0900

    refactoring

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 9063019
Author: kyoichi-sugahara <[email protected]>
Date:   Tue Jun 13 13:22:49 2023 +0900

    refactor

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 5fe015a
Merge: ab7d208 f09e575
Author: kyoichi-sugahara <[email protected]>
Date:   Tue Jun 13 12:56:28 2023 +0900

    Merge branch 'main' into feature/create_predicted_path_from_target_velcoity

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit ab7d208
Author: kyoichi-sugahara <[email protected]>
Date:   Sat Jun 10 01:17:41 2023 +0900

    refactoring

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 6eb0dae
Author: kyoichi-sugahara <[email protected]>
Date:   Sat Jun 10 00:54:05 2023 +0900

    delete debug print

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 57e75c4
Author: kyoichi-sugahara <[email protected]>
Date:   Sat Jun 10 00:52:06 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 89bfa91
Merge: abaf563 fc08b4f
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 21:26:18 2023 +0900

    Merge branch 'main' into feature/create_predicted_path_from_target_velcoity

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit abaf563
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 20:37:08 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 1b32573
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 20:00:41 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 9db1416
Merge: 1ae32a3 21b6403
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 19:23:51 2023 +0900

    Merge branch 'main' into feature/create_predicted_path_from_target_velcoity

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 1ae32a3
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 18:45:19 2023 +0900

    create PredictedPath debug marker

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 1bc6451
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 15:45:09 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 6c78054
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 14:55:22 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit df7cbc1
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 14:43:52 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 0210dc1
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 14:31:58 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit f01e8e1
Merge: d9f8edb 35f94d0
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 12:17:24 2023 +0900

    Merge branch 'main' into feature/add_safety_checker_pull_out

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit d9f8edb
Author: kyoichi-sugahara <[email protected]>
Date:   Fri Jun 9 12:07:51 2023 +0900

    temo

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit b206444
Author: Tomoya Kimura <[email protected]>
Date:   Thu Jun 8 22:32:40 2023 +0900

    fix(behavior_path_planner): avoid invalid access (autowarefoundation#3923)

    Signed-off-by: tomoya.kimura <[email protected]>

commit 6aa9f02
Author: Zulfaqar Azmi <[email protected]>
Date:   Thu Jun 8 18:02:30 2023 +0900

    fix(behavior_path_planner): small refactoring for resamplePathWithSpline (autowarefoundation#3922)

    Signed-off-by: Zulfaqar Azmi <[email protected]>

commit 880216a
Author: Tomoya Kimura <[email protected]>
Date:   Thu Jun 8 17:34:31 2023 +0900

    fix(compare_map_segmentation): initialize timer_callback_group_ (autowarefoundation#3914)

    Signed-off-by: tomoya.kimura <[email protected]>

commit 920a0cb
Author: kyoichi-sugahara <[email protected]>
Date:   Thu Jun 8 19:14:32 2023 +0900

    update

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit a75cf49
Merge: e27face 69e89d9
Author: kyoichi-sugahara <[email protected]>
Date:   Thu Jun 8 16:30:09 2023 +0900

    Merge branch 'main' into feature/add_safety_checker_pull_out

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit e27face
Author: kyoichi-sugahara <[email protected]>
Date:   Tue Jun 6 19:36:32 2023 +0900

    temp

    Signed-off-by: kyoichi-sugahara <[email protected]>

commit 7ec623e
Author: kyoichi-sugahara <[email protected]>
Date:   Tue Jun 6 16:29:51 2023 +0900

    add function to create PredictedPath from target velocity

    Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
Merge branch 'main' into feat/safety_checker_class
ed0d5ff 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
temp
733d894 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
define SafetyCheckParams
9444316 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
temp
2fe4d76 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
Merge branch 'main' into feat/safety_checker_class
aca5c45 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
update:build success
ba53ca8 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
add create predicted path function
56093e9 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
add getBackwardLanelets
d2551ff 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
add filterObjectIndices
b201bc5 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
add getEgoExpectedPoseAndConvertToPolygon
57ebfbc 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
add isSafeInLaneletCollisionCheck
d5f24bb 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
add utilfunction
a87ac95 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
refactor
c11b0dc 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
temp
ac8b572 
Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 20, 2023
@kyoichi-sugahara
delete unncesarry file
78b8721 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
temp
14e75a0 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
define new structur for data
12eb23f 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
refactor
4e65824 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
add doxygen
ba1d11a 
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara
add doc
1bf3599 
Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jun 21, 2023
kyoichi-sugahara and others added 2 commits June 21, 2023 10:59
kosuke55
kosuke55 reviewed Jun 21, 2023
View reviewed changes
.../behavior_path_planner/include/behavior_path_planner/utils/safety_checker/safety_checker.hpp
Comment on lines +145 to +150
explicit SafetyChecker(
const std::shared_ptr<SafetyCheckParams> & safety_check_params,
const std::shared_ptr<SafetyCheckData> & safety_check_data)
: safety_check_params_{safety_check_params}, safety_check_data_{safety_check_data}
{
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a constructor with only params to make an instance in the module constructor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and updateSafetyCheckData function

@stale
Copy link

stale bot commented Oct 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 8, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Nov 9, 2023
@stale Stale
Copy link

stale bot commented Jan 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 8, 2024
@kyoichi-sugahara kyoichi-sugahara deleted the feat/safety_checker_class branch July 22, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosuke55 kosuke55 kosuke55 left review comments

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyoichi-sugahara @kosuke55