ci: add JSON Schema validation #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverage the json-schema-check action from the autoware-github-actions repository. Issue-Id: SCM-6366 Signed-off-by: Ambroise Vincent <[email protected]> Change-Id: I5f284e96b2eddc652a6da8c0338f92c411277c04
github-actions
bot
added
the
type:ci
kenji-miyake
approved these changes
Jun 30, 2023
Co-authored-by: Kenji Miyake <[email protected]>
|
Ah, using the Github commit of suggestion doesn't pass the DCO check. I can force push if it's a problem. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to autowarefoundation/autoware-github-actions#240
Leverage the json-schema-check action from the autoware-github-actions repository.
Relates to #2652
Tests performed
Made sure it ran fine and could fail on wrong files with: https://github.com/ambroise-arm/autoware.universe/actions/runs/5411918092
Effects on system behavior
Will trigger the action on changes to schema and parameter files.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.