feat(ndt_scan_matcher): remake diag #5076
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method ndt_scan_matcher_core.cpp: NDTScanMatcher::callback_sensor_points_main
- Large Method ndt_scan_matcher_core.cpp: NDTScanMatcher::NDTScanMatcher
✅ Improving Code Health:
- Complex Method ndt_scan_matcher_core.cpp: NDTScanMatcher::callback_sensor_points
- Complex Method ndt_scan_matcher_core.cpp: NDTScanMatcher::publish_diagnostic
- Complex Conditional ndt_scan_matcher_core.cpp: NDTScanMatcher::publish_diagnostic
Annotations
Check notice on line 598 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
NDTScanMatcher::callback_sensor_points is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 202 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
NDTScanMatcher::publish_diagnostic is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 598 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
NDTScanMatcher::callback_sensor_points_main has a cyclomatic complexity of 25, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 192 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
NDTScanMatcher::NDTScanMatcher increases from 106 to 111 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 199 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
NDTScanMatcher::publish_diagnostic no longer has a complex conditional