feat(goal_planner): prioritize goals before objects to avoid #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
kosuke55
added
the
run:build-and-test-differential
Merged
7 tasks
kosuke55
force-pushed
the
feat/goal_priority_behind_objects
branch
from
a863a00 to
d8e27da
Compare
|
need to update path priority too.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5137 +/- ##
==========================================
- Coverage 14.87% 14.86% -0.01%
==========================================
Files 1627 1627
Lines 112557 112632 +75
Branches 34744 34784 +40
==========================================
+ Hits 16743 16744 +1
- Misses 77064 77133 +69
- Partials 18750 18755 +5
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kosuke55
force-pushed
the
feat/goal_priority_behind_objects
branch
from
d8e27da to
4d67fdf
Compare
github-actions
bot
added
the
type:documentation
|
#5137 (comment) |
kosuke55
force-pushed
the
feat/goal_priority_behind_objects
branch
2 times, most recently
from
60ad986 to
e2612f8
Compare
Signed-off-by: kosuke55 <[email protected]> sort path priority Signed-off-by: kosuke55 <[email protected]> update docs Signed-off-by: kosuke55 <[email protected]> typo Signed-off-by: kosuke55 <[email protected]>
kosuke55
force-pushed
the
feat/goal_priority_behind_objects
branch
from
e2612f8 to
8e85385
Compare
| void update(GoalCandidates & goal_candidates) const override; | ||
|
|
||
| private: | ||
| void countObjectsToAvoid( |
There was a problem hiding this comment.
[NITS] countObjectsToPass is more intuitive for me.
|
smart! |
kyoichi-sugahara
approved these changes
Sep 27, 2023
|
@kyoichi-sugahara |
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 3, 2023
…efoundation#5137) sort path priority update docs typo Signed-off-by: kosuke55 <[email protected]>
7 tasks
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prioritize goals before objects to avoid.
gray numbers are the number of objects to avoid
object not to avoid
object to avoid
goal_search_avoidance_objects-2023-09-26_16.12.00.mp4
Related links
none
Tests performed
psim
2023/09/27 https://evaluation.tier4.jp/evaluation/reports/d7c68b5d-3232-5881-8f18-71c2203f11b3/?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.