Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ndt_scan_matcher): removed duplicate parameter declarations "initial_pose_timeout_sec_" #5153

Conversation

SakodaShintaro
Copy link
Contributor

Description

Removed duplicate parameter declarations initial_pose_timeout_sec_

#4916

Tests performed

logging_simulator on sample rosbag

Effects on system behavior

The ndt_scan_matcher node will not crash.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro self-assigned this Sep 27, 2023
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Sep 27, 2023
@SakodaShintaro SakodaShintaro added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:localization Vehicle's position determination in its environment. (auto-assigned) labels Sep 27, 2023
@SakodaShintaro SakodaShintaro enabled auto-merge (squash) September 27, 2023 05:54
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (bb89363) 14.87% compared to head (a54d5d1) 14.87%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5153      +/-   ##
==========================================
- Coverage   14.87%   14.87%   -0.01%     
==========================================
  Files        1627     1627              
  Lines      112546   112555       +9     
  Branches    34744    34744              
==========================================
  Hits        16743    16743              
- Misses      77052    77061       +9     
  Partials    18751    18751              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.87% <ø> (+<0.01%) ⬆️ Carriedforward from bb89363

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...clude/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp 100.00% <ø> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit 0f19d71 into autowarefoundation:main Sep 27, 2023
29 of 32 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/ndt_scan_matcher_remove_duplicate_param_declaration branch September 27, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants