Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_cmd_gate): fix the problems while transition from/to stopped state #5183

Merged
merged 1 commit into from
Feb 9, 2024

fix(vehicle_cmd_gate): fix the problems while transition from/to stop…

19b03ae
Select commit
Loading
Failed to load commit list.
Merged

fix(vehicle_cmd_gate): fix the problems while transition from/to stopped state #5183

fix(vehicle_cmd_gate): fix the problems while transition from/to stop…
19b03ae
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 2, 2024 in 58s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method vehicle_cmd_gate.cpp: VehicleCmdGate::publishControlCommands

Annotations

Check warning on line 443 in control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

VehicleCmdGate::publishControlCommands increases in cyclomatic complexity from 12 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis