refactor(vehicle_cmd_gate): move isSteerConverged debug marker from trajectory_follower #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
brkay54
force-pushed
the
refactor/move-convergence-marker
branch
2 times, most recently
from
99036e4 to
8bd3363
Compare
7 tasks
brkay54
force-pushed
the
refactor/move-convergence-marker
branch
from
8bd3363 to
5b23d90
Compare
…ped state Signed-off-by: Berkay Karaman <[email protected]>
Signed-off-by: Berkay Karaman <[email protected]>
…rajectory_follower Signed-off-by: Berkay Karaman <[email protected]>
brkay54
force-pushed
the
refactor/move-convergence-marker
branch
from
5b23d90 to
49c9ad6
Compare
|
Closed because of the latest discussions in main PR: #5183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5189
Because we removed the checking if steering converged or not from
controller_node, I recreated the marker publisher in vehicle_cmd_gate.Tests performed
Tested on psim, worked well.
Effects on system behavior
No effects
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.