perf(ndt_scan_matcher): changed default initial_estimate_particles_num to 200
#5220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <[email protected]>
github-actions
bot
added
the
component:localization
4 tasks
SakodaShintaro
requested review from
KYabuuchi,
kminoda,
Motsu-san and
YamatoAndo
as code owners
YamatoAndo
approved these changes
Oct 4, 2023
kminoda
added
the
tag:run-build-and-test-differential
KYabuuchi
approved these changes
Oct 4, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5220 +/- ##
=======================================
Coverage 14.79% 14.79%
=======================================
Files 1648 1648
Lines 113918 113918
Branches 35074 35074
=======================================
Hits 16859 16859
Misses 78135 78135
Partials 18924 18924
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Oct 11, 2023
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 16, 2023
…um` to 200 (autowarefoundation#5220) Changed initial_estimate_particles_num to 200 Signed-off-by: Shintaro Sakoda <[email protected]>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 16, 2023
…um` to 200 (autowarefoundation#5220) Changed initial_estimate_particles_num to 200 Signed-off-by: Shintaro Sakoda <[email protected]>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 16, 2023
…um` to 200 (autowarefoundation#5220) Changed initial_estimate_particles_num to 200 Signed-off-by: Shintaro Sakoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I propose to change the default value of
initial_estimate_particles_num, mainly because the initial pose estimation at AWSIM Nishi-Shinjuku fails about 10% of the time.Related link
autowarefoundation/autoware_launch#618
Evaluation
Performed 1000 initial position estimations and recorded TP scores.
initial_estimate_particles_num= 100mean_score: 5.171 ± 1.488
mean_elapsed_time: 0.537 ± 0.036 [sec]
initial_estimate_particles_num= 200mean_score: 5.938 ± 0.911
mean_elapsed_time: 1.073 ± 0.043 [sec]
The TP score improves, but processing time is approximately doubled.
Tests performed
Tested by
Effects on system behavior
Improves the performance of initial position estimation, but it takes more time in default parameters.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.