Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): add visualization for passParkedObject #5291

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Due to passParkedObject function returns false, debug visualization didn't publish any Markers due to no information is registed to the object_debug_. This PR fixes this issue by updating the object_debug_ information in the passParkedObject function.

Screenshot from 2023-10-12 23-02-49

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 12, 2023
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (02eb843) 14.83% compared to head (a22ab3d) 14.83%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5291      +/-   ##
==========================================
- Coverage   14.83%   14.83%   -0.01%     
==========================================
  Files        1649     1649              
  Lines      114278   114767     +489     
  Branches    35384    35720     +336     
==========================================
+ Hits        16956    17027      +71     
- Misses      78176    78522     +346     
- Partials    19146    19218      +72     
Flag Coverage Δ *Carryforward flag
differential 12.56% <22.22%> (?)
total 14.84% <ø> (+<0.01%) ⬆️ Carriedforward from 02eb843

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 7.81% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <ø> (ø)
...ath_planner/src/scene_module/avoidance/manager.cpp 5.94% <0.00%> (-0.05%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.09% <0.00%> (-0.02%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.44% <0.00%> (-0.01%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 13.56% <0.00%> (-0.03%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 12.85% <26.66%> (+0.63%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit f1cf22b into autowarefoundation:main Oct 13, 2023
29 of 32 checks passed
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lane-change-visualization-for-parked branch October 16, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants