Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(euclidean cluster): update the broken link #5292

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

sezan92
Copy link
Contributor

@sezan92 sezan92 commented Oct 12, 2023

The given link was broken. I have updated with the correct link.

Note: Confirm the contribution guidelines before submitting a pull request.

Click the Preview tab and select a PR template:

Do NOT send a PR with this description.

The given link was broken. I have updated with the correct link.
@sezan92 sezan92 requested a review from yukkysaito as a code owner October 12, 2023 14:07
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Oct 12, 2023
@sezan92
Copy link
Contributor Author

sezan92 commented Oct 12, 2023

@yukkysaito sorry i forgot to sign off. is it fine for such a small change?

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR 👍
LGTM

@yukkysaito yukkysaito enabled auto-merge (squash) October 13, 2023 01:13
@yukkysaito yukkysaito added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 13, 2023
@yukkysaito yukkysaito changed the title Fix: Update the broken link fix(euclidean cluster): update the broken link Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (744d48d) 14.87% compared to head (2d6c26c) 14.83%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5292      +/-   ##
==========================================
- Coverage   14.87%   14.83%   -0.04%     
==========================================
  Files        1649     1654       +5     
  Lines      114317   114554     +237     
  Branches    35403    35403              
==========================================
- Hits        17001    16999       -2     
- Misses      78129    78367     +238     
- Partials    19187    19188       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.87% <ø> (-0.01%) ⬇️ Carriedforward from 4ba8923

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
.../scene_module/goal_planner/goal_planner_module.cpp 5.62% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sezan92 sezan92 disabled auto-merge October 13, 2023 02:44
@sezan92
Copy link
Contributor Author

sezan92 commented Oct 13, 2023

@yukkysaito i am not sure how to merge, as i do not see any merge button

@yukkysaito yukkysaito merged commit 7e0031e into autowarefoundation:main Oct 13, 2023
20 of 23 checks passed
@yukkysaito
Copy link
Contributor

@sezan92 No problem 👍 I'll merge them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants