Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): fix chattering for stopped objects #5302

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 13, 2023

Description

fix chattering for stopped objects
the cause is that object direction and extending direction is chattering when stopped.

after

lc_chattering-2023-10-13_16.45.30.mp4

Related links

Tests performed

psim

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 13, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (910f30b) 14.83% compared to head (376e2da) 14.79%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5302      +/-   ##
==========================================
- Coverage   14.83%   14.79%   -0.04%     
==========================================
  Files        1662     1662              
  Lines      115035   115405     +370     
  Branches    35476    35748     +272     
==========================================
+ Hits        17066    17077      +11     
- Misses      78738    79073     +335     
- Partials    19231    19255      +24     
Flag Coverage Δ *Carryforward flag
differential 12.56% <37.93%> (?)
total 14.83% <ø> (-0.01%) ⬇️ Carriedforward from 910f30b

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
..._safety_checker/path_safety_checker_parameters.hpp 33.33% <ø> (ø)
...g/behavior_path_planner/src/marker_utils/utils.cpp 5.75% <0.00%> (-0.02%) ⬇️
...g/behavior_path_planner/test/test_safety_check.cpp 40.24% <0.00%> (ø)
...ner/src/utils/path_safety_checker/safety_check.cpp 22.41% <50.00%> (+0.38%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <[email protected]>

Update planning/behavior_path_planner/src/utils/path_safety_checker/safety_check.cpp

fix(path_safety_checker): remove redundant parameter name

Signed-off-by: Fumiya Watanabe <[email protected]>
@rej55 rej55 merged commit b266f47 into main Oct 15, 2023
20 of 24 checks passed
@rej55 rej55 deleted the fix/lc_chattering branch October 15, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants