refactor(mpc_lateral_controller): minor refactor for updateOffset #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
requested review from
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:control
TakaHoribe
reviewed
Oct 18, 2023
control/mpc_lateral_controller/src/steering_offset/steering_offset.cpp
Outdated
Show resolved
Hide resolved
…fset.cpp Co-authored-by: Takamasa Horibe <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 9aae0a9
Renamed a parameter and a variable in
mpc_lateral_controllerto improve readability and clarity. Added a comment to explain the calculation of the expected steering angle insteering_offset.cpp.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.